Solo skipped tests shouldn't be reported by failures-only or compact reporters #2546
Conversation
|
I don't think I agree with treating solo differently than other skipped tests. I think I can get on board with suppressing all skips in the compact and failures only reporters. |
|
I'll start a conversation with a few folks to make a decision on what behavior we want to switch to and revisit this. |
Well, I guess it makes no difference too. Now that you said it, I realized that skipped tests wouldn't have any message to send so this would work fine too. I'll wait for your answer (after the discussions), to continue working on this. Thank you for taking a look at it already! |
|
I've updated this to remove the Small note: in the related issue, I mentioned this idea came from @jakemac53 at dart-lang/tools#2107 (comment) to help out in debugging analyzer (and related) tests. |
|
Do note that by removing that |
The issue I'm trying to fix is #2542.
I've used the
skipinformation to skip allMessages writes when inside the relevant reporters.I've already copied and added some tests here.
I'd like some guidance on whether what I did was the correct implementation (first contribution here). And once I've resolved all requests from the team, I'll add the new entry to the changelog and bump the version as needed.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.